Use correct value for \Ds\Vector::MIN_CAPACITY #1832
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PECL's
\Ds\Vector::MIN_CAPACITYwas updated from 10 to 8 for PECL DS 1.2.0, August 2017 (back in the PHP 5.5 days).The PHP official documentation was never updated though, so this is likely the cause of these stubs to still use the old value. The official PECL DS polyfill does use the correct value since 2017 already.
See:
MIN_CAPACITYconstants php/doc-en#5082MIN_CAPACITYvalue in DS C implementation: https://github.com/php-ds/ext-ds/blob/master/src/ds/ds_vector.h#L12MIN_CAPACITYvalue in DS PHP polyfill: https://github.com/php-ds/polyfill/blob/master/src/Vector.php#L23