Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PECL's
DSclasses cannot be extended, as they are optimized C implementations.Attempting to extend a DS class causes PHP to emit a fatal error:
However, PHPStorm won't warn about this, because the stubs don't specify these classes as being final.
The official PECL DS polyfill (see: https://github.com/php-ds/polyfill/tree/master/src) does use the
finalkeyword for the class definitions.This PR adds the
finalkeyword to the PECLDSclass stubs, so that PHPStorm's code inspection correctly warns about attempting to extend a PECL DS class.