Conversation
Extended allowedContactKeys()
|
My apologies for taking so long to get to this. I looked over what you've done and I like it. I am thinking we might want a way to configure whether the postal address is included or not because it seems to add a significant amount of data to each contact and I don't want to slow down the user experience. In the issue you opened you mentioned that the PR needed some modifications. What sort of modifications were you thinking of? |
|
Is there any chance of this getting merged? |
|
@Tom-Fox1 could you answer @JettF 's questions from above? If you could confirm that this doesn't have any more modifications that need to be made, and just fix the merge conflict, I'll ensure it gets merged in. |
|
@JettF as far as determining which fields are included, that should probably be the case for all fields. We should create an enum for the fields and pass it in the initializer, probably with a default value. |
|
@AnthonyMDev I didn't author this PR so don't know about the potential need for modification mentioned by @Sub-Zero-1. What @JettF said about adding address a a config option to keep a fast UX may still need to be looked at. I just chimed in as this is something that is make or break for my use case. |
|
Ah sorry. Wasn’t paying attention to the author. I think we should get this pulled in then. Let me take another look. We can probably add the config options pretty easily.
…Sent from my iPhone
On Feb 12, 2019, at 12:47, Tom Fox ***@***.***> wrote:
@AnthonyMDev I didn't author this PR so don't know about the potential need for modification mentioned by @Sub-Zero-1.
What @JettF said about adding address a a config option to keep a fast UX may still need to be looked at.
I just chimed in as this is something that is make or break for my use case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
No worries, thanks for responding so quickly! |
4 participants
No description provided.