fix(server): honour MSSQL_SERVER env var fallback#9
Open
vineet-reddy wants to merge 1 commit intoJexinSam:mainfrom
Open
fix(server): honour MSSQL_SERVER env var fallback#9vineet-reddy wants to merge 1 commit intoJexinSam:mainfrom
vineet-reddy wants to merge 1 commit intoJexinSam:mainfrom
Conversation
MSSQL_SERVER was used by dependent projects but ignored by get_db_config(). The new lookup chain resolves that mismatch (`MSSQL_HOST` → `MSSQL_SERVER` → default localhost)."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSSQL_SERVER was used by dependent projects but ignored by get_db_config(). The new lookup chain resolves that mismatch (
MSSQL_HOST→MSSQL_SERVER→ default localhost)."Problem
get_db_config()only reads MSSQL_HOST, yet many examples (andthe companion medinsight project) export MSSQL_SERVER. This makes
the server silently fall back to
localhost, causing logintimeouts.
Fix
Add a fallback:
MSSQL_HOST→MSSQL_SERVER→ default.Notes
pytest -q).