feat: Add GitKraken support with custom path arguments#234
Open
dotWee wants to merge 1 commit intoJi4n1ng:masterfrom
Open
feat: Add GitKraken support with custom path arguments#234dotWee wants to merge 1 commit intoJi4n1ng:masterfrom
dotWee wants to merge 1 commit intoJi4n1ng:masterfrom
Conversation
Adds support for opening repositories in GitKraken using the `--path` argument. The implementation follows the pattern used by other custom terminal apps like neovim and kitty. GitKraken requires special handling to properly open repositories with the correct path argument. Key changes: - Added GitKraken to supported terminal applications - Implemented custom command handling for GitKraken paths - Added bundle identifier for GitKraken app detection - Made command configurable through user defaults like other terminals Users can now open folders directly in GitKraken from Finder using the context menu or toolbar. The implementation preserves path escaping and handles spaces in paths correctly. Custom command configuration allows users to modify the launch behavior if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of this pull request
Adds support for opening repositories in GitKraken using the
--pathargument.The implementation follows the pattern used by other custom terminal apps like neovim and kitty. GitKraken requires special handling to properly open repositories with the correct path argument.
Key changes:
Users can now open folders directly in GitKraken from Finder using the context menu or toolbar. The implementation preserves path escaping and handles spaces in paths correctly.
Custom command configuration allows users to modify the launch behavior if needed.
Does this solve an existing issue? If so, add a link to it
Fixes #233.
Steps to test this feature
Screenshots
Additional info
On a different note, thank you @Ji4n1ng for your open source work! Your work is really appreciated!
Maybe think about adding a buymeacoffee.com link to your profile, and your next coffee/beer is on me! ;)