Upgrade to AGP 8.5.2

[mzennis]

Compile Success

Changes

• upgrade to AGP 8.5.2 (compatible with Android Studio Koala | 2024.1.1 Patch 2)
• upgrade Gradle wrapper to 8.7 (comply with https://developer.android.com/build/releases/gradle-plugin)
• upgrade Firebase to latest version
• set minimum sdk to 21
• disable android.nonTransitiveRClass
• disable android.nonFinalResIds

[Uuptupyy]

(
(http.host eq "api.example.com" and http.request.uri.path eq "/api/v2/auth") or
(http.host matches "^(www|store|blog).example.com" and http.request.uri.path contains "wp-login.php") or
ip.geoip.country in {"CN" "TH" "US" "ID" "KR" "MY" "IT" "SG" "GB"} or ip.geoip.asnum in {12345 54321 11111}
) and not ip.src in {11.22.33.0/24}

[jyyi1]

We still need to lock the dependencies, this might lead to a large amount of changes.

[mzennis]

hi @jyyi1 please help to re-review my PR, I was adding three more commits:

• a35b414
• cfe5ca1
• 2d8b7ac

let me know if you have any feedback

[jyyi1]

Thanks for the update. I have left some comments.

[jyyi1]

I think this comment is not accurate any more?

Suggested change

	implementation 'com.google.firebase:firebase-analytics:22.1.2' // Last version for API <19
	implementation 'com.google.firebase:firebase-analytics:22.1.2'

[jyyi1]

Are we using it anywhere in the code? If not, I think we can remove this.

[mzennis]

yes, we are actually using it (code:

Intra/Android/app/src/main/java/app/intra/sys/firebase/LogWrapper.java

Line 19 in 5a48272

import app.intra.BuildConfig;

)

but, we could change the implementation, instead of using BuildConfig. like, differentiate LogWrapper for release and debug (src/debug/) mode. wdyt?

[jyyi1]

Are these two settings necessary?

[mzennis]

well, starting Android Gradle Plugin (AGP) version 8.0 and above, the default value for:
android.nonTransitiveRClass & android.nonFinalResIds are true.

• android.nonTransitiveRClass => each module's R class only includes resources defined within that specific module. It does not include resources from its dependencies.
• android.nonFinalResIds => means that resource IDs are generated as non-final by default, allowing for potential modifications at runtime.

and, we are using those in:

Also, I don't think we need to change how it's done, since I'm worried it might mess up other stuff.

[mzennis]

my suggestion is, if we're going to change these, we should do it in a separate PR. wdyt?

[Fakrul877]

Bagus dan terima kasih untuk amati segalanya mungkin tak bisa saya dalami dan saya juga pengguna baru tolong lah beri tunjuk ajar

[jyyi1]

FYI, I have created #544 to only upgrade AGP to the minimum viable version (without too much dependency update), this should unblock most of the work flows.

[mzennis]

FYI, I have created #544 to only upgrade AGP to the minimum viable version (without too much dependency update), this should unblock most of the work flows.

thank you! I will close the PR then 👍🏻