Skip to content

Replace generics in the path finding layer with dynamic dispatch#13

Merged
Jinderamarak merged 17 commits intomainfrom
dynamic-dispatch
Apr 10, 2025
Merged

Replace generics in the path finding layer with dynamic dispatch#13
Jinderamarak merged 17 commits intomainfrom
dynamic-dispatch

Conversation

@Jinderamarak
Copy link
Copy Markdown
Owner

@Jinderamarak Jinderamarak commented Apr 10, 2025

Replaced generics in a few traits since they were used only with dynamic dispatch and simplified the usage.

Increases the MSRV to 1.86.0 since it uses trait upcasting coercion.

Closes #4

@Jinderamarak Jinderamarak requested a review from Copilot April 10, 2025 16:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.

Comment thread safe-stage/paths/src/common/sight.rs Outdated
Comment thread safe-stage/models/src/lib.rs Outdated
@Jinderamarak Jinderamarak merged commit a146015 into main Apr 10, 2025
7 checks passed
@Jinderamarak Jinderamarak deleted the dynamic-dispatch branch April 10, 2025 20:10
Jinderamarak added a commit that referenced this pull request Apr 10, 2025
refactor: better name instead of generic arc

refactor: replace generics with dyns

test: add complex path search example

refactor: introduce immovable type

test: remove multiple iterations

refactor: remove unused code

test: rename integration test case

fix: replace remaining inconsistent types

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: revert unintentional change

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: cleanup copilot suggestions

fix: pipeline not running on pull request

chore: increase msrv

ci: run tests on msrv

ci: add missing components

ci: always build bindings in release

ci: ignore unused features in testing

ci: merge safe stage runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider replacing generics with dyn since it cannot be avoided anyway

2 participants