Skip to content

fix unnecessary checkbox#20

Open
tophermoa wants to merge 4 commits intoJitensid:mainfrom
tophermoa:feature/hide_checkbox
Open

fix unnecessary checkbox#20
tophermoa wants to merge 4 commits intoJitensid:mainfrom
tophermoa:feature/hide_checkbox

Conversation

@tophermoa
Copy link

Fix this #18

@Jitensid Jitensid added enhancement New feature or request hacktoberfest labels Oct 16, 2022
@Jitensid
Copy link
Owner

Your tests are failing. Please check...

@tophermoa
Copy link
Author

Hello.
I push more commit, already tested. Please kindly check.

@Jitensid
Copy link
Owner

Could you write unit tests for your updated change ?

@tophermoa
Copy link
Author

Okay i'll working on it.

@tophermoa
Copy link
Author

I updated a few line of code on DownloadTabsList.test.js. Change selector for checkbox with .querySelector because .getByRole gets undefined even the component just set to display: none

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #20 (4eb6084) into main (a5503a5) will decrease coverage by 0.09%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   86.87%   86.78%   -0.10%     
==========================================
  Files           9        9              
  Lines         221      227       +6     
  Branches       34       36       +2     
==========================================
+ Hits          192      197       +5     
- Misses         29       30       +1     
Impacted Files Coverage Δ
...rc/components/DownloadTabsList/DownloadTabsList.js 95.38% <85.71%> (-1.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tophermoa
Copy link
Author

tophermoa commented Nov 5, 2022

Any update or review on this PR? @Jitensid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants