Changed die() statements to custom exceptions and added a new constructor option.#1
Open
Dragory wants to merge 1 commit intoJoeynoh:masterfrom
Open
Changed die() statements to custom exceptions and added a new constructor option.#1Dragory wants to merge 1 commit intoJoeynoh:masterfrom
Dragory wants to merge 1 commit intoJoeynoh:masterfrom
Conversation
…. Also added an option to change the timestamp format in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a custom Exception class LogException and replaced the class's die() statements with LogException throws.
I also added a third parameter to the constructor that allows the user to change the timestamp format.
(I also combined the public/const keywords for the class properties/constants.)