Skip to content

Merge refactored Plantonic Solid module#99

Merged
yingyue2030699 merged 8 commits intodevfrom
pLLMantonicSolid
Jan 20, 2026
Merged

Merge refactored Plantonic Solid module#99
yingyue2030699 merged 8 commits intodevfrom
pLLMantonicSolid

Conversation

@yingyue2030699
Copy link
Member

@yingyue2030699 yingyue2030699 commented Jan 20, 2026

  • refactored the platonic solid module to a clear structure of a subpackage + two files
  • fixed the wrong geometry (e.g. the tetrahedron geometry was wrong)
  • removed redundant API from the ionerdss init
  • fixed associated unittests

Tasks to consider:

  • Integration tests for platonic solid modules
  • Remove "round to n" from all the subpackages for platonic solid modules
  • Move integration test .cifs to dedicated folder under unittest and avoid fetching them (currently failing in github actions)

@yingyue2030699 yingyue2030699 merged commit ccd62bc into dev Jan 20, 2026
5 of 11 checks passed
@yingyue2030699 yingyue2030699 deleted the pLLMantonicSolid branch January 20, 2026 21:25
@yingyue2030699 yingyue2030699 added bug Something isn't working enhancement New feature or request labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants