Minor bugfixes and getting started guide update#9
Minor bugfixes and getting started guide update#9Johnsonajibi merged 3 commits intoJohnsonajibi:mainfrom
Conversation
…nt encoding components for consistency between fingerprints. Corrected getting-started.md.
Johnsonajibi
left a comment
There was a problem hiding this comment.
Thank you for the fixes. The deterministic fingerprint update looks correct - removing the time-variant collected_at field from the encoding while retaining it for debugging is appropriate, and the explicit equality implementation resolves the timestamp inconsistency cleanly.
CI and security checks are currently failing (lint / test / APIsec). Please review the failing job logs and push an update addressing the issues. I’ll proceed with approval and merge once the pipeline is green.
|
G'day mate,
Honestly, this is my first PR to a project so I'm a little lost on what all
those things mean. However I've had a scan through them (on mobile) and I
can't see much in the way of details, but the things I can see details on
(predominantly the linter check) seem to be failing on a lot of files that
I didn't even touch. And a lot of the security and matrix ones seem to be
failing far before even attempting to run the code.
How sure are you that the pipeline was all green before my PR because I
added like 10 lines of code in total and didn't add anything that should
have affected backwards compatibility so any tests that passed before
should still pass?
If you have any information you can point me towards I'll have a good look
at it and see what my code may have affected. But a lot of those fails
don't look related to my changes.
Regards
Michael
…On Sat, 28 Feb 2026, 8:22 pm Johnson Ajibi, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you for the fixes. The deterministic fingerprint update looks
correct - removing the time-variant collected_at field from the encoding
while retaining it for debugging is appropriate, and the explicit equality
implementation resolves the timestamp inconsistency cleanly.
CI and security checks are currently failing (lint / test / APIsec).
Please review the failing job logs and push an update addressing the
issues. I’ll proceed with approval and merge once the pipeline is green.
—
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG34LW6SQRXIHPOKUNNQ3A34OFT5BAVCNFSM6AAAAACWCI7XHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNZQGM2DIOBXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Johnsonajibi
left a comment
There was a problem hiding this comment.
Hi Michael,
Thanks for working through that. The remaining failures were actually down to CI configuration on my side rather than your changes — I’ve adjusted the workflow and everything’s green now.
The fingerprint update looks good and the formatting fix cleared the lint issue. I’ll merge this through.
Appreciate you taking the time to contribute.
Added fingerprint equality check to compare fingerprint attributes only - timestamp attribute caused inequality between fingerprints generated at different times using implicit equality check. Removed collected_at from fingerprint encoding components for consistency between fingerprints generated at different times. Left it in components to retain debugging functionality and retain backwards compatibility. Corrected function call in getting-started.md to make tutorial work as intended.