Skip to content

Minor bugfixes and getting started guide update#9

Merged
Johnsonajibi merged 3 commits intoJohnsonajibi:mainfrom
Sarcastic-Pharm:main
Feb 28, 2026
Merged

Minor bugfixes and getting started guide update#9
Johnsonajibi merged 3 commits intoJohnsonajibi:mainfrom
Sarcastic-Pharm:main

Conversation

@Sarcastic-Pharm
Copy link
Contributor

Added fingerprint equality check to compare fingerprint attributes only - timestamp attribute caused inequality between fingerprints generated at different times using implicit equality check. Removed collected_at from fingerprint encoding components for consistency between fingerprints generated at different times. Left it in components to retain debugging functionality and retain backwards compatibility. Corrected function call in getting-started.md to make tutorial work as intended.

…nt encoding components for consistency between fingerprints. Corrected getting-started.md.
Copy link
Owner

@Johnsonajibi Johnsonajibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes. The deterministic fingerprint update looks correct - removing the time-variant collected_at field from the encoding while retaining it for debugging is appropriate, and the explicit equality implementation resolves the timestamp inconsistency cleanly.

CI and security checks are currently failing (lint / test / APIsec). Please review the failing job logs and push an update addressing the issues. I’ll proceed with approval and merge once the pipeline is green.

@Sarcastic-Pharm
Copy link
Contributor Author

Sarcastic-Pharm commented Feb 28, 2026 via email

Copy link
Owner

@Johnsonajibi Johnsonajibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael,

Thanks for working through that. The remaining failures were actually down to CI configuration on my side rather than your changes — I’ve adjusted the workflow and everything’s green now.

The fingerprint update looks good and the formatting fix cleared the lint issue. I’ll merge this through.

Appreciate you taking the time to contribute.

@Johnsonajibi Johnsonajibi merged commit 3bf8557 into Johnsonajibi:main Feb 28, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants