Add data- attributes to configure behaviour
#11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, what do you think about implementing some
data-attributes that can be set on the HTML canvas, to allow klee users to set some configuration.Use case: I have found benefit from having our klee blueprints behave in a few ways that are different from the defaults:
My first goal is to not affect any of the default klee behaviour, so that everything works exactly the same for users who don't care about this.
But it is nice to allow users to set some config options if they want.
I have implemented that here using HTML
data-attributes.Example usage:
Tests:
data-camera-position="top-left": it starts in top left, zooms near where you aredata-camera-position-height-offsetprovided the UI adjusts down that many pixels for starting + return positiondata-top-left-xanddata-top-left-yare provided the canvas reads and uses supplied values