-
Notifications
You must be signed in to change notification settings - Fork 10
Add pin types #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add some null checks for subCategoryObject
06013a5 to
2fe3809
Compare
Contributor
Author
|
You can now see in #8 - I have added unit tests to prove that this code works. |
Unreal draws an square box filled with the color value - e.g. a white or red box. Currently klee just lists the rgba number values in a line. draw the colored box instead.
…to add-pin-types
Contributor
Author
martinhodler
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Add parsing support for a few missing pin types
serializeAsSinglePrecisionFloatsubPinsparentPinDesiredPinDirectionUserDefinedPinrealpin type (make it green, same asfloat)PinFriendlyNameforINVTEXTsubCategoryObjectto preventUncaught TypeError: can't access property "class", i.subCategoryObject is undefined. Without these several node and pin types do not display.This patch removes a number of errors from the browser console like
Tests: I created one node for each of these pin types and verified that they display correctly.
1) Nodes in Unreal:

2) Before This Patch: Nodes in current main code

(note you will need to add the null checks for this to render; otherwise it will not display)
3) After This Patch: Nodes display more correctly
