Conversation
added 2 commits
April 15, 2026 00:18
Adds a real Pitch Bend VST3 parameter (plus-minus 12 semitones, automatable) separate from Vowel. The hardware MIDI pitch wheel is routable to either Vowel (Classic / Delay Lama compat, default) or Pitch via a new right-click submenu; the host is notified via restartComponent(kMidiCCAssignmentChanged) so the switch takes effect without a plugin reload. The submenu label reflects the active mode. DSP changes apply the pitch offset in MIDI-note space inside the voice synthesis loop, upstream of the Hz-space unison detune, so all unison voices shift together while preserving their spread. Dead monk_synth_pitch_bend function (which just redirected to set_vowel) removed. Refactors the DSP sources into a monk_dsp static library so the plugin and a new opt-in test target can both link the same objects. Adds a minimal assert.h + CTest suite covering pitch-bend clamping, ADSR envelope boundaries, note-stack LIFO, unison detune math, and delay feedback stability. Tests are gated behind -DMONKSYNTH_BUILD_TESTS=ON and run on the Linux CI job before packaging so regressions block releases. Pitch Bend submenu localized into English, Japanese, and Korean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a context menu option for assigning hardware pitch bend to actual pitch bend instead of vowel. Gives users a new way to play the synth.
There's also a small DSP test suite.