This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Add scroll bar functionality to terminal widget #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKs
commented
Jun 25, 2024
| }; | ||
| let pseudo_terminal = PseudoTerminal::new(screen); | ||
| let pseudo_terminal = PseudoTerminal::new(screen) | ||
| .scroll((self.app_state.terminal_scroll, 0)); // Added scroll functionality based on AppState::terminal_scroll |
Owner
Author
There was a problem hiding this comment.
There's no .scroll function on the PsuedoTerminal Widget
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a GitHub Workspaces test!
Related to #1
This pull request introduces scroll functionality to the terminal widget in the Skoglab/terminal-ai-ops project, enhancing user interaction by allowing them to navigate through terminal output.
AppState Modifications:
terminal_scrolltoAppStateto keep track of the scroll position within the terminal widget.terminal_scrollto0inAppState::new, ensuring a default starting position at the top of the terminal output.UI Service Enhancements:
rendermethod inUiServiceto incorporate scrolling logic, enabling the terminal widget to display content based on the current scroll position stored inAppState::terminal_scroll.startmethod to handle key events for scrolling up and down. Specifically, pressing the up arrow decreasesterminal_scrollby 1, and pressing the down arrow increasesterminal_scrollby 1, allowing users to navigate through the terminal output.terminal_scrollfrom decrementing below 0, ensuring that users cannot scroll past the beginning of the terminal output.For more details, open the Copilot Workspace session.