(Issue #183) Deprecated pandas function usage fix#184
Open
gauravpradeep wants to merge 1 commit intoJonasSchult:mainfrom
Open
(Issue #183) Deprecated pandas function usage fix#184gauravpradeep wants to merge 1 commit intoJonasSchult:mainfrom
gauravpradeep wants to merge 1 commit intoJonasSchult:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of .append with pandas DataFrames has been deprecated. This introduces a bug in scannet_preprocessing.py as mentioned in #183 .
This PR fixes #183 and preserves expected behaviour so as not to affect downstream usage of the preprocessed data.