Add session site to login check in load function#66
Open
brucetony wants to merge 2 commits intoJonathanHolvey:masterfrom
Open
Add session site to login check in load function#66brucetony wants to merge 2 commits intoJonathanHolvey:masterfrom
brucetony wants to merge 2 commits intoJonathanHolvey:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load function would crash because the session.auth.login() call requires a website, so I passed the session.site to it. There is still a bug in which the refresh() and login() methods both return
None, but the load method checks these and expectsTrueso they need to be updated to return a boolean.