joybus: Fix first bit being skipped when console is being turned on #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenoArrows
force-pushed
the
master
branch
3 times, most recently
from
16e44cc to
195539a
Compare
ZenoArrows
changed the title
There's no need for it anymore since we're resetting the ISR anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the console is being turned on the data line is initially low because the console is powered off. This causes joybus-pio to incorrectly conclude that the first MSB bit is 0. The simple fix for this issue is to wait until the data line becomes high before entering the read loop.
However this doesn't work if the console is reset, since we are already in the loop by then. Thus for a complete fix we need to detect if the data line actually returns to a high value, if it doesn't then we should reset the loop by emptying the ISR and waiting for the data line to become high again.
I also included a trivial commit that includes a missing header in the examples.