Conversation
We can't handle ipv6 addresses, so we ignore them if given as parameter. We use the IP of the remote given with the connection. That is either ipv4, when listening on ipv4 or it is not and we fail later.
Owner
Author
|
I have a "dual stack" connection, running ipv4 and ipv6, using ipv6 where available. KTorrent is sending my ipv6 address in the query, leading to the error |
Owner
Author
|
I (still) do not intend to fully maintain peertracker, but I wanted to make this fix available. I only fixed this in the "mysql branch". This still needs fixing in the postgres and sqlite "braches" and the actual fix would probably be to not duplicate that part of the code.. |
Owner
Author
|
I am not saying KTorrent does the right thing, but handling this case in this way shouldn't hurt. See also http://www.bittorrent.org/beps/bep_0007.html for "real" ipv6 handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't handle ipv6 addresses, so we ignore them if given as parameter.
We use the IP of the remote given with the connection.
That is either ipv4, when listening on ipv4
or it is not and we fail later.