Closed
Conversation
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: ST1543 <sammyt1544@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: QT1543 <quinnt1543@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
Signed-off-by: Jordan Ye <yejordan8888@gmail.com>
feat(quarantine): added schema and manifest
feat(quarantine): add manifest load/save helpers
Replace benchmarks with real benchmarks
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the changes proposed in #151, mostly following the outlined function prototypes and requirements. For all the edges cases I caught them and propagated an error up to the client. I leave implementation of what to do to the CLI. A lot of the code involving permissions is very messy due to the differences between unix and windows. It might be worth looking into a more OS agnostics method to achieve what we want. In implementing this I noticed a problem with how we handle original file permissions as there was no system suggested for restoring windows file permissions which we do edit as part of making a file read only. This required me to implement a very janky system to deal with how we store permissions and should be fixed/changed in a later issue.
Related Issue
Fixes #151
Type of Change
How to Test
Checklist
cargo fmt+cargo clippy)cargo test)