Open
Conversation
Replace string-matched already-current handling with a typed updater outcome and add a non-force version-upgrade CLI test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update-dbto the existingDatabaseUpdaterusing the shared app-data path--force, server/network failures, checksum mismatch, and corrupt manifest handlingThis completes the MVP update-db CLI contract so end users can actually update their signature database from remote sources.
Related Issue
Closes #155
Closes #186
Closes #196
Closes #166
Closes #206
Type of Change
How to Test
./scripts/validate_strict.shcargo test --test update_db_cli -- --nocapturecargo test integration::updater_fallback_test::test_updater_fallback_logic --test integration_tests -- --nocapturecargo test integration::database_tests::test_database_updater_no_update_when_version_matches --test integration_tests -- --nocapturecargo test integration::database_tests::test_database_updater_manifest_and_checksum --test integration_tests -- --ignored --nocaptureChecklist
cargo fmt+cargo clippy)cargo test)