Refactor: add Bitmap ScoreTxt as an option for Optimization#1473
Open
moxie-coder wants to merge 3 commits intomainfrom
Open
Refactor: add Bitmap ScoreTxt as an option for Optimization#1473moxie-coder wants to merge 3 commits intomainfrom
moxie-coder wants to merge 3 commits intomainfrom
Conversation
currently it's skewed to the left, and doesn't update properly
Owner
|
idk why, but when i use the Bitmap scoreTxt, the score text is smaller than when you don't use it. |
Collaborator
Author
I’ve noticed this, I’ll fix it in a moment |
Collaborator
Author
I've re-exported it, and it definitely looks far better than before honestly. I think this might be good |
NAEL2XD
reviewed
Mar 13, 2026
|
|
||
| function setScoreText(value:String) | ||
| { | ||
| if (Std.isOfType(scoreTxt, FlxText)) |
There was a problem hiding this comment.
could've done if (scoreTxt is FlxText)
Collaborator
Author
There was a problem hiding this comment.
could've done
if (scoreTxt is FlxText)
that method is deprecated, this is the newer method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes GC not go insane when the text is updated every frame, however it breaks some compatibility with some mods that rely on
setFormatand such for the ScoreTxt, which is why it's optional as an setting.TODO: