Fix for polygroups and masks #553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version was losing its position in the binary when parsing the polypaint data, causing all data that was parsed after polypaint to be lost, including polygroup and mask data. Fixed by checking ahead for the next data type tag after each polypaint block is parsed. Disclaimer: Understanding exactly how to parse and check all this binary data went a bit above my head, so I used AI a lot here to help me. Worth double checking it didn't do something weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write of polypaint parsing as the previous version was losing its position in the binary, resulting in it missing the tags for the data types that followed, eg masks and polygroups. Fixed by checking ahead for the next data type tag after each polypaint block is parsed.
Disclaimer: Understanding exactly how to parse and check all this binary data went a bit above my head, so I used AI a lot here to help me. Worth double checking it didn't do something weird.