fix the ugi security bug of OrcInputFormat which is caused by thread-…#1
Open
VicoWu wants to merge 1 commit intoJoshRosen:release-1.2.1-spark2from
Open
fix the ugi security bug of OrcInputFormat which is caused by thread-…#1VicoWu wants to merge 1 commit intoJoshRosen:release-1.2.1-spark2from
VicoWu wants to merge 1 commit intoJoshRosen:release-1.2.1-spark2from
Conversation
Owner
|
Process-wise, I think the right thing to do here is for us to work with the Hive project to publish Spark's fork of Hive via the official Hive release process. There are some proposals of how to do this at https://issues.apache.org/jira/browse/HIVE-16391. Maybe we should ping that thread to try to reach consensus with the Hive team on the right way to proceed? |
|
@JoshRosen |
Author
|
@JoshRosen @maver1ck , so, should we merge it or close this PR? |
Author
|
@JoshRosen @maver1ck moved this PR to https://github.com/apache/hive/pull/504/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in SPARK-11248, the spark thrift server have security bugs , cause the result that user A sometimes have the authority of user B and User B sometimes have the authority of user A in turn. I debugged it and I find that it is caused by the hive 1.2.1 library , OrcInputFormat.java, in which a thread pool is created to contact with remote HDFS. Since threads in pool is reused and shared, so , when thread-1-pool-1 is used by user A previously and after that user B is assigned to this thread in coincidence, then user B will have the security context of User A.
I have fixed this bug by add UserGroupInformation in this pool, to make sure that when a user is assigned a thread, then the security is switched to this user at the same time.