Skip to content

Conversation

@tylersayshi
Copy link

first: I love create-typescript-app... it was a fantastic way for me to get my project off the ground with good feeling lint defaults and not having to think much about it 🙌

this is only a recommendation and the more correct fix would be better default tab spaces view on npmjs.com, but that sounds unlikely?

here's an example of when it's bad
https://www.npmjs.com/package/prototypey/v/0.2.3
vs with spaces
https://www.npmjs.com/package/prototypey/v/0.2.4

PR Checklist

Overview

This is a recommendation as a default so others don't go through the same pain with npm after publishing, but please feel free to just close if this is out of scope for the project or anything.

this is only a recommendation and the better fix would be better default
tab spaces view on npmjs.com, but that sounds unlikely?

here's an example of when it's bad
https://www.npmjs.com/package/prototypey/v/0.2.3
vs with spaces
https://www.npmjs.com/package/prototypey/v/0.2.4
@github-actions
Copy link

👋 Hi @tylersayshi, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

@tylersayshi
Copy link
Author

I realize this issue is not yet marked accepting PRs but had already made the minor changes, so figured i'd leave them 😅

@JoshuaKGoldberg
Copy link
Owner

I appreciate you so much for sending this!! Switching to draft pending discussion in #2277 but at the very least it's great as a reference. Thank you!

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft October 23, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Tooling: suggestion to use spaces only for readme.md b/c of npmjs.com

2 participants