Add side_pindir parameter to rp2.asm_pio signature #837
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
rp2.asm_pio()
function signature in the reference stubs to include the newside_pindir
parameter introduced in micropython/micropython#16506.Changes
Added the
side_pindir: bool = False
parameter to theasm_pio()
decorator function in/reference/micropython/rp2/__init__.pyi
.Parameter Details
The
side_pindir
parameter controls how.side()
modifiers behave in PIO assembly programs:False
(default):.side()
modifiers control pin valuesTrue
:.side()
modifiers control pin directions instead of pin valuesDocumentation Updates
side_pindir
parametersideset_init
parameter documentation to use the more precise.side()
modifiers terminology, matching the official MicroPython documentation styleValidation
✅ All
ruff check
andruff format
validations passed✅ Type annotations are correct (
bool
type withFalse
default)✅ Documentation follows the existing style and format
Fixes #793
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/micropython/micropython/pulls/16506
curl -s REDACTED
(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #793
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.