Add market transactions pagination#6505
Merged
Lezek123 merged 3 commits intoJoystream:devfrom May 9, 2025
Merged
Conversation
…ctionsPagination hook, accomodate code to integrate pagination
Lezek123
requested changes
May 9, 2025
Lezek123
approved these changes
May 9, 2025
Collaborator
Lezek123
left a comment
Lezek123
left a comment
There was a problem hiding this comment.
LGTM, it fixes the original issue, although a better solution would be to fetch only a page of ammTransaction at once, instead of pre-fetching all of them.
Lezek123
added a commit
to Lezek123/atlas
that referenced
this pull request
May 9, 2025
* Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination * Remove unnecessary comment * Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts --------- Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Lezek123
added a commit
that referenced
this pull request
May 9, 2025
* Add YPP referral pagination (#6503) * Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work * Update VITE_YOUTUBE_SYNC_API_URL in .env * Add market transactions pagination (#6505) * Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination * Remove unnecessary comment * Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts --------- Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com> * Update CHANGELOG and bump versions --------- Co-authored-by: Edvin Dzidic <edvindzidic2000@gmail.com>
Lezek123
added a commit
to Lezek123/atlas
that referenced
this pull request
May 9, 2025
* Add YPP referral pagination (Joystream#6503) * Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work * Update VITE_YOUTUBE_SYNC_API_URL in .env * Add market transactions pagination (Joystream#6505) * Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination * Remove unnecessary comment * Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts --------- Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com> * Update CHANGELOG and bump versions --------- Co-authored-by: Edvin Dzidic <edvindzidic2000@gmail.com>
Lezek123
added a commit
to Joystream/gleev
that referenced
this pull request
May 9, 2025
* Add YPP referral pagination (Joystream#6503) * Add hook which correctly fetches and paginates ypp referral data, integrate hook and add necessary changes to make it work * Update VITE_YOUTUBE_SYNC_API_URL in .env * Add market transactions pagination (Joystream#6505) * Move fetching functionality and add pagination within useMarketTransactionsPagination hook, accomodate code to integrate pagination * Remove unnecessary comment * Update packages/atlas/src/hooks/useMarketTransactionsPagination.ts --------- * Update CHANGELOG and bump versions --------- Co-authored-by: Edvin Dzidic <edvindzidic2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR aims to fix the issue described here: #6438
cc @Lezek123