Add a SKIP_ORION option to the start script#5091
Open
thesan wants to merge 1 commit intoJoystream:masterfrom
Open
Add a SKIP_ORION option to the start script#5091thesan wants to merge 1 commit intoJoystream:masterfrom
SKIP_ORION option to the start script#5091thesan wants to merge 1 commit intoJoystream:masterfrom
Conversation
mnaamani
requested changes
Mar 21, 2024
Member
mnaamani
left a comment
mnaamani
left a comment
There was a problem hiding this comment.
This makes sense, I find myself doing the same as well.
But we still need storage-squid to run ..
| ./start-orion.sh | ||
|
|
||
| ## Storage Squid | ||
| docker-compose -f ./docker-compose.storage-squid.yml up -d |
Member
There was a problem hiding this comment.
I don't think you mean to also prevent storage-squid from starting up if SKIP_ORION == true
The storage infra needs it to function, as they do not rely on query node anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a DX thing but I keep on adding this to the start script.
Here's why: only Atlas usues Orion, and a lot of the work on Atlas is done using a playgrounds ATM. OTOH when working on Orion directly IMO it's easier to run Orion from the local repository not from the monorepos.