Conversation
Lezek123
left a comment
Lezek123
left a comment
There was a problem hiding this comment.
Thank you for making the PR, I left a small comment regarding notification tests, as there have been some changes related to those in Orion 5.0.
It seems like your branch fails to build after you updated it from master: https://github.com/Joystream/orion/actions/runs/15605914961/job/44001244476?pr=366, so please fix the code in notifications.test.ts.
| } | ||
| case 'CommentPostedToVideo': { | ||
| const { videoId, videoTitle, memberId, memberHandle } = notificationType | ||
| const { videoId, videoTitle, memberId, memberHandle, comentId } = notificationType |
There was a problem hiding this comment.
| const { videoId, videoTitle, memberId, memberHandle, comentId } = notificationType | |
| const { videoId, videoTitle, memberId, memberHandle, commentId } = notificationType |
| return { | ||
| icon: await getNotificationIcon(em, 'follow'), | ||
| link: await getNotificationLink(em, 'nft-page', [videoId]), | ||
| link: await getNotificationLink(em, 'video-page', [videoId, comentId]), |
There was a problem hiding this comment.
| link: await getNotificationLink(em, 'video-page', [videoId, comentId]), | |
| link: await getNotificationLink(em, 'video-page', [videoId, commentId]), |
| }, | ||
| } | ||
| before(async () => { | ||
| nextNotificationIdPre = await getNextNotificationId(overlay, true) |
There was a problem hiding this comment.
This will no longer work in Orion v5, as the notification ids are randomly generated, please see the adjustments to notifications tests that I made here: https://github.com/Joystream/orion/pull/365/files#diff-4ecb12693f9548f4c9bf50d647cf34ac9bd0f648f61151c72cda0c2d2fbc139a
2 participants
fix for #352