forked from conda/constructor
-
Notifications
You must be signed in to change notification settings - Fork 1
Test frozen #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jrice1317
wants to merge
16
commits into
metadata
Choose a base branch
from
test_frozen
base: metadata
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test frozen #7
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
53924d3
Update example construct.yaml
Jrice1317 0d796e0
Update wording in example
Jrice1317 5550721
Move comment
Jrice1317 dcda8bd
Expand test
Jrice1317 1d8457b
Add comment for expected RuntimeError
Jrice1317 f06bd3a
Add EOF whitespace
Jrice1317 af8736c
Remove extra_files logic to be done in own test; expect runtime error
Jrice1317 bdfd87b
Remove tested runtime error
Jrice1317 59fb173
Use context as params to test with and without conflict
Jrice1317 c08c138
First attempt to fix broken logic
Jrice1317 9c95bde
Fix logic?
Jrice1317 6900a17
Rearrange
Jrice1317 c5059df
Raise subprocess error instead of RuntimeError
Jrice1317 f5eb126
Remove RuntimeError assertion
Jrice1317 a4252f0
Remove conflict from construct.yaml
Jrice1317 6fb8314
Refactor test for cleaner conflict validation
Jrice1317 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {} | ||
| {"message": "This env is frozen via extra_files."} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, your
construct.yamlfile is the one that's broken. It would be much nicer if you committed the one that's working to the repository and then add this later for the negative test case.