Skip to content

Avoid StackOverflow in promote_type with Any #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid StackOverflow in promote_type with Any #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9fa0cb
Avoid StackOverflow in promote_type with Any
dlfivefifty Dec 5, 2024
766e6b2
Update src/promote.jl
blegat Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/promote.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ function promote_rule_constant(
return term_type(TT, promote_type(S, T))
end

function promote_rule_constant(
::Type{Any},
::Type{<:AbstractTermLike{T}},
) where {T}
return Any
end

# PolynomialLike
Base.promote_rule(::Type{PT}, ::Type{PT}) where {PT<:_APL} = PT
function Base.promote_rule(PS::Type{<:_APL}, PT::Type{<:_APL})
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
TypedPolynomials = "afbbf031-7a57-5f58-a1b9-b774a0fad08d"

[compat]
DynamicPolynomials = "0.5"
DynamicPolynomials = "0.5, 0.6.2"
TypedPolynomials = "0.4"
6 changes: 6 additions & 0 deletions test/promote.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,9 @@ end
__promote_prod(PXY, PXY, PXY)
end
end

@testset "promote_operation with Any" begin
Mod.@polyvar x
V = typeof(x)
@test promote_type(V, Any) == Any
end
1 change: 1 addition & 0 deletions test/test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[deps]
Loading