Skip to content

Implement equality between ExponentsIterator #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement equality between ExponentsIterator #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
108ab98
Implement equality between ExponentsIterator
blegat Sep 11, 2025
030c17c
Merge branch 'master' into bl/exp_==
blegat Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/comparison.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,13 @@ function Base.IteratorSize(::Type{<:ExponentsIterator{M,Int}}) where {M}
return Base.HasLength()
end

function Base.:(==)(a::ExponentsIterator, b::ExponentsIterator)
return typeof(a.object) == typeof(b.object) &&
length(a.object) == length(b.object) &&
a.mindegree == b.mindegree &&
a.maxdegree == b.maxdegree
end

function _length(it::ExponentsIterator, maxdegree)
if maxdegree < it.mindegree
return 0
Expand Down
9 changes: 9 additions & 0 deletions test/comparison.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ function _test(nvars::Int, M; kws...)
return
end

function test_equal()
exp = ExponentsIterator{LexOrder}([0])
@test exp == ExponentsIterator{LexOrder}([0])
@test exp != ExponentsIterator{LexOrder}((0,))
@test exp != ExponentsIterator{LexOrder}([0, 0])
@test exp != ExponentsIterator{LexOrder}([0], mindegree = 1)
@test exp != ExponentsIterator{LexOrder}([0], maxdegree = 2)
end

function test_errors()
err = ArgumentError(
"The `mindegree` of `ExponentsIterator` cannot be negative.",
Expand Down