This repository was archived by the owner on Oct 21, 2021. It is now read-only.
Update connected_components.jl#188
Open
sbromberger wants to merge 3 commits intoJuliaAttic:masterfrom
sbromberger:patch-2
Open
Update connected_components.jl#188sbromberger wants to merge 3 commits intoJuliaAttic:masterfrom sbromberger:patch-2
sbromberger wants to merge 3 commits intoJuliaAttic:masterfrom
sbromberger:patch-2
Conversation
This fixes the bug in #187. It seems appropriate to check for `w_color > 0` instead of `==1` since it shouldn't matter here that the vertex hasn't been explored. We're doing a dfs for each vertex whose colormap !=0 in any case.
Contributor
Author
|
Hm. Apparently the fix that works for LightGraphs doesn't carry over to Graphs. Let me dig some more. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug in #187. It seems appropriate to check for
w_color > 0instead of==1since it shouldn't matter here that the vertex hasn't been explored. We're doing a dfs for each vertex whose colormap !=0 in any case.That said, I'm not really an expert in Tarjan's algorithm, so please review it :)