Fix CircularBuffer inner constructor #949
Conversation
| function CircularBuffer{T}(iter, capacity::Integer) where {T} | ||
| vec = copyto!(Vector{T}(undef,capacity), iter) | ||
| CircularBuffer{T}(1, length(iter),vec) | ||
| vec = copyto!(Vector{T}(undef, capacity), iter) | ||
| CircularBuffer{T}(1, length(iter), vec) | ||
| end | ||
|
|
||
| CircularBuffer(capacity::Integer) = CircularBuffer{Any}(capacity) | ||
|
|
||
| CircularBuffer{T}(capacity::Integer) where {T} = CircularBuffer{T}(T[],capacity) | ||
| CircularBuffer{T}(capacity::Integer) where {T} = CircularBuffer{T}(T[], capacity) | ||
|
|
||
| CircularBuffer(iter,capacity::Integer) = CircularBuffer{eltype(iter)}(iter,capacity) | ||
| CircularBuffer(iter, capacity::Integer) = CircularBuffer{eltype(iter)}(iter, capacity) | ||
|
|
||
| function CircularBuffer{T}(iter) where {T} | ||
| vec = reshape(collect(T,iter),:) | ||
| vec = reshape(collect(T, iter), :) | ||
| CircularBuffer{T}(1, length(vec), vec) | ||
| end |
There was a problem hiding this comment.
These are just formatting fixes
| f <= length(buf) || throw(ArgumentError("Value of 'first' must be inbounds of buffer")) | ||
| len <= length(buf) || throw(ArgumentError("Value of 'length' must be <= length of buffer")) | ||
| return new{T}(length(buf), f, len, buf) | ||
| end | ||
|
|
||
| # Convert any `Integer` to whatever `Int` is on the relevant machine | ||
| CircularBuffer{T}(f::Integer, len::Integer, buf::Integer) where {T} = CircularBuffer{T}(Int(f), Int(len), Int(buf)) |
There was a problem hiding this comment.
This constructor could be removed entirely, as it was just never called in the previous version. However it seems that #893 decided to keep it
rossviljoen
force-pushed
the
rv/circularbuffer-fixes
branch
from
1feac5b to
b6058cf
Compare
|
What is this fixing? |
|
Nothing was actually broken before. The issue is that there is an inner constructor: This constructor was already superfluous because of #893 (comment) , so there's no change in behaviour, but this PR just implements the original intention in that linked PR. |
No description provided.