Skip to content

Remove string interpolation in show #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove string interpolation in show #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09cc32e
Remove string interpolation in `show`
devmotion Sep 4, 2025
07c51fa
Add tests
devmotion Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.jl.cov
*.jl.*.cov
*.jl.mem
Manifest.toml
5 changes: 2 additions & 3 deletions src/DiffResults.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,7 @@ hessian!(f, r::DiffResult, x) = derivative!(f, r, x, Val{2})
# Pretty Printing #
###################

Base.show(io::IO, r::ImmutableDiffResult) = print(io, "ImmutableDiffResult($(r.value), $(r.derivs))")

Base.show(io::IO, r::MutableDiffResult) = print(io, "MutableDiffResult($(r.value), $(r.derivs))")
Base.show(io::IO, r::ImmutableDiffResult) = print(io, "ImmutableDiffResult(", r.value, ", ", r.derivs, ")")
Base.show(io::IO, r::MutableDiffResult) = print(io, "MutableDiffResult(", r.value, ", ", r.derivs, ")")

end # module
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ using DiffResults: DiffResult, GradientResult, JacobianResult, HessianResult,
@test rs === DiffResult(s0, s1, s2)
@test rsmix === DiffResult(n0, s0, s1)

@test repr(rn) == "ImmutableDiffResult($n0, ($n1, $n2))"
@test repr(rx) == "MutableDiffResult($x0, ($x1, $x2))"
@test repr(rs) == "ImmutableDiffResult($s0, ($s1, $s2))"
@test repr(rsmix) == "ImmutableDiffResult($n0, ($s0, $s1))"

@test issimilar(GradientResult(x0), DiffResult(first(x0), x0))
@test issimilar(JacobianResult(x0), DiffResult(x0, similar(x0, k, k)))
@test issimilar(JacobianResult(similar(x0, k + 1), x0), DiffResult(similar(x0, k + 1), similar(x0, k + 1, k)))
Expand Down
Loading