Skip to content

Conversation

@DilumAluthgeBot
Copy link
Contributor

Stdlib: ArgTools
Branch: master
Old commit: fa87869
New commit: 641aa3f
Bump invoked by: @StefanKarpinski

$ git log --oneline fa87869..641aa3f
641aa3f no lock: pass lock=false to file open calls (#23)
1ff44c8 Merge pull request #22 from DilumAluthge/dpa/gha-windows
6c1199b Run CI on Windows
21a396d Merge pull request #21 from DilumAluthge/dpa/github-actions-ci
064c813 Add GitHub Actions CI and remove Travis CI
b83f736 README.md: fix typos (#17)

@vtjnash
Copy link
Member

vtjnash commented May 11, 2021

no lock: pass lock=false to file open calls

Wait, this sounds like a bad idea from the title

@StefanKarpinski
Copy link
Member

It is documented and last I was aware doing locking was a major performance issue.

@StefanKarpinski
Copy link
Member

@vtjnash: I'm going to merge this unless I get a clear statement to the effect that locking is no longer a performance issue for I/O.

@StefanKarpinski StefanKarpinski self-assigned this Jun 7, 2021
@ChrisRackauckas
Copy link
Member

aaronang/stl-benchmark#3 is an example of a benchmark that gets hit by the lock performance issue.

@KristofferC
Copy link
Member

It does seem non-ideal to me that open is thread-safe by default but that a standard library function (which is a small wrapper around open) changes that default to be unsafe. At least it should have the same kwarg option as open with the same default and propagate that to the inner open call?

@vtjnash
Copy link
Member

vtjnash commented Jun 7, 2021

propagating any ; kwargs... seems sensible

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/ArgTools-641aa3f branch June 9, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants