Skip to content

actually add the atributes #44097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2022
Merged

actually add the atributes #44097

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bda6a96
actually add the atributes
Feb 9, 2022
dfc9941
fix windows CI failure?
Feb 9, 2022
6f74237
typo
Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/codegen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,9 +476,9 @@ static AttributeList get_func_attrs(LLVMContext &C)
static AttributeList get_donotdelete_func_attrs(LLVMContext &C)
{
AttributeSet FnAttrs = AttributeSet::get(C, makeArrayRef({Attribute::get(C, "thunk")}));
FnAttrs.addAttribute(C, Attribute::InaccessibleMemOnly);
FnAttrs.addAttribute(C, Attribute::WillReturn);
FnAttrs.addAttribute(C, Attribute::NoUnwind);
FnAttrs = FnAttrs.addAttribute(C, Attribute::InaccessibleMemOnly);
FnAttrs = FnAttrs.addAttribute(C, Attribute::WillReturn);
FnAttrs = FnAttrs.addAttribute(C, Attribute::NoUnwind);
return AttributeList::get(C,
FnAttrs,
Attributes(C, {Attribute::NonNull}),
Expand Down Expand Up @@ -3480,7 +3480,7 @@ static bool emit_builtin_call(jl_codectx_t &ctx, jl_cgval_t *ret, jl_value_t *f,
// For now we emit this as a vararg call to the builtin
// (which doesn't look at the arguments). In the future,
// this should be an LLVM builtin.
auto it = builtin_func_map.find(jl_f_donotdelete);
auto it = builtin_func_map.find(jl_f_donotdelete_addr);
if (it == builtin_func_map.end()) {
return false;
}
Expand Down