Revert #44101, revert #44097, and revert #43852 #44123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#44097 is unrelated |
|
#44105 is related though, but only affects doctests so this should be enough to test your hypothesis. |
Yeah I just noticed that the doctests are failing, but yeah I agree, let's first see what the testers say. |
This was referenced Feb 11, 2022
|
@Keno Except for the doctests, all CI jobs are passing on d21e8eb (https://buildkite.com/julialang/julia-master/builds/8632) I'm going to remove the revert of #44097 and add a revert of #44105. |
DilumAluthge
force-pushed
the
dpa/revert-43852-44097-44101
branch
from
d21e8eb to
d844050
Compare
|
If all CI jobs pass, I'd be fine with merging this PR, with the plan of re-landing the three reverted PRs once the underlying bug is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now believe that the recent CI breakage had nothing to do with the public https://badssl.com/ instance. Instead, I believe that the breakage was caused by one (or more) of the following pull requests:
ConstResultif available #44101 (fed4544)This PR reverts the above three PRs.