RFC: Avoid running out of memory by checking available memory before allocating #46831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_(total_free)_memory.
…ating. This improves the user experience when running with a memory constraint, e.g. in a container, where malloc wouldn't fail but instead the OOM killer would terminate the process.
Member
|
Could we put this behind a command line flag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the user experience when running with a memory constraint, e.g. in a container, where
mallocwouldn't fail but instead the OOM killer would terminate the process (which people have been frequently complaining about). #46796 improves the situation by using appropriate GC heuristics, but this PR would make it mostly impossible to overallocate.RFC because: