[JuliaLowering] ccall((lib,sym)...) and cfunction fixes
#60257
+59
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ccall` with a `lib,sym` tuple argument was being desugared to a call to
`Core.Tuple` when we actually want an `Expr(:tuple)`
- `cfunction` only worked in simple cases, since the check for local variables
in scope resolution will fail with any nontrivial function body. I know
that using the new `static_eval` head could be considered a bugfix (see
discussion at JuliaLang/JuliaLowering.jl#36), but
this PR just uses `inert` to match Base.
stdlib status: 38/51
mlechu
added
the
compiler:lowering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccallwith alib,symtuple argument was being desugared to a call toCore.Tuplewhen we actually want anExpr(:tuple)cfunctiononly worked in simple cases, since the check for local variables in scope resolution will fail with any nontrivial function body. I know that using the newstatic_evalhead could be considered a bugfix (see discussion at AddK"static_eval"for cfunction/ccall/cglobal JuliaLowering.jl#36), but this PR just usesinertto match Base.stdlib status: 38/51 (with #60255)