MersenneTwister: fix constructor involving jumped state #60258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`show` for `MersenneTwister` outputs valid input syntax, by dumping a condensed state, which can be used to reconstruct the real state. In the case where an rng is used, then jumped, the output state was triggering an assertion error when parsed back; this assertion was wrong, so remove it. For example: ``` julia> m = MersenneTwister(123); rand(m); Random.jump!(m, big(10)^20) MersenneTwister(0xf80cc98..., 0xea7a7d..., 100000000000000000000, 1002) julia> MersenneTwister(0xf80cc98..., 0xea7a7d..., 100000000000000000000, 1002) ERROR: AssertionError: adv == 0 Stacktrace: [...] ```
rfourquet
added
randomness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showforMersenneTwisteroutputs valid input syntax, by dumping a condensed state, which is used by the constructor to reconstruct the real state.In the case where
randis called on an instance which is then jumped, the output state was triggering an assertion error when parsed back; this assertion was wrong, so remove it. For example: