release-1.12: Revert "build: More msys2 fixes (#59028)" #60374
+26
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89c2a4e.
KristofferC
requested review from
LilithHafner,
d-netto and
giordano
as code owners
KristofferC
changed the title
ararslan
reviewed
Dec 12, 2025
|
|
||
| $(BUILDDIR)/host/$(EXENAME): $(BUILDDIR)/host/Makefile | ${BUILDDIR}/host/flisp.boot | ||
| $(MAKE) -C $(BUILDDIR)/host $(EXENAME) | ||
| make -C $(BUILDDIR)/host $(EXENAME) |
Member
There was a problem hiding this comment.
This actually should be $(MAKE); if this works as-is on FreeBSD then it must not be getting called there since make is not GNU Make.
Member
There was a problem hiding this comment.
Huh yeah this PR builds and passes all tests on FreeBSD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causes
USE_BINARYBUILDER=0to fail.