Merged
Conversation
…, I'm currently gettting the same undefined symbol for legate::detail::processor_id() as discussed in the meeting
Member
|
I've re-added OpenBlas32_jll in the Project.toml; however, we should avoid doing so. The deps/build.jl script required it. We can potentially leverage LIBPATH from cupynumeric_jll and make that a CMAKE_PREFIX_PATH for the developer build mode. |
Member
|
However, this has broke the pkg resolve between legate and cupynumeric within the CI. I'm not entirely sure why it works on my end, but not the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all the unnecessary JLL dependencies we had in order to dlopen them. This mimics the changes in Legate.jl.
This PR also moves the CUDA code to a package extension. I know for a fact this will not work. We need to do the following:
This is because package extensions can not export their own methods, they must instead extend methods that exist in the base package.