Skip to content

Add BlockSkylineLayout #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add BlockSkylineLayout #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/AbstractBlockBandedMatrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
const BlockBandedColumnMajor = BlockBandedColumns{ColumnMajor}
const BlockBandedRowMajor = BlockBandedRows{ColumnMajor}

blockbandedcolumns(lay) = BlockBandedColumns{typeof(lay)}()

Check warning on line 32 in src/AbstractBlockBandedMatrix.jl

View check run for this annotation

Codecov / codecov/patch

src/AbstractBlockBandedMatrix.jl#L32 

Added line #L32 was not covered by tests

transposelayout(::BandedBlockBandedColumns{Lay}) where Lay = BandedBlockBandedRows{Lay}()
transposelayout(::BandedBlockBandedRows{Lay}) where Lay = BandedBlockBandedColumns{Lay}()
transposelayout(::BlockBandedColumns{Lay}) where Lay = BlockBandedRows{Lay}()
Expand Down
7 changes: 6 additions & 1 deletion src/BlockSkylineMatrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,12 @@
# BlockSkylineMatrix Interface #
################################

MemoryLayout(::Type{<:BlockSkylineMatrix}) = BlockBandedColumnMajor()
struct BlockSkylineColumns{Lay} <: AbstractBlockLayout end

blockskylinelayout(lay, ::Type{<:BlockBandedSizes}) = blockbandedcolumns(lay)
blockskylinelayout(lay, _) = BlockSkylineColumns{typeof(lay)}()

Check warning on line 372 in src/BlockSkylineMatrix.jl

View check run for this annotation

Codecov / codecov/patch

src/BlockSkylineMatrix.jl#L371-L372 

Added lines #L371 - L372 were not covered by tests

MemoryLayout(::Type{<:BlockSkylineMatrix{T,DATA,BS}}) where {T,DATA,BS} = blockskylinelayout(MemoryLayout(DATA), BS)

Check warning on line 374 in src/BlockSkylineMatrix.jl

View check run for this annotation

Codecov / codecov/patch

src/BlockSkylineMatrix.jl#L374 

Added line #L374 was not covered by tests
colblockbandwidths(A::BlockSkylineMatrix) = (A.block_sizes.l, A.block_sizes.u)
blockbandwidths(A::BlockSkylineMatrix) = maximum.(colblockbandwidths(A))
BroadcastStyle(::Type{<:BlockSkylineMatrix}) = BlockSkylineStyle()
Expand Down