Conversation
This should address #123 as well, making the strategy compatible with the early access version of Julia 1.12.
Member
Author
|
@nystrom, can you please have a look at this? |
nystrom
reviewed
Sep 8, 2025
Member
Author
|
@nickrobinson251 @nystrom Can one of you please review this? If I don't hear from you in a week, I'm just going to merge and register a new patch revision. |
- Replace ReTest with Julia's built-in Test package in test/runtests.jl - Remove ReTest dependency from test/Project.toml - Add Test package dependency to test/Project.toml - All tests continue to pass (974 tests) - Enables compatibility with Julia 1.12 and nightly builds This addresses the issue where ReTest doesn't compile on Julia 1.12 development versions, preventing test execution on newer Julia versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #123 as well, making the
strategy compatible with the early access version
of Julia 1.12.
Besides simplifying the handling of nested macros within
@match, this fixes an incompatibility with the Julia 1.12 rewrite of the Julia macro implementation. The issue #123 has links to the Julia issues. We now use the "normal" recursive version of the macro expansion function, as the non-recursive version is what "caused" the error. The incompatibility might or might not be fixed in Julia before 1.12 is released, but with this change it doesn't matter. It works with all Julia versions equally well.Testing against the Julia nightly version failed because the nightly breaks the
ReTestpackage. I did test this by hand against the most recent 1.12 preview and it doesn't have the issue reported in #123.Fixes #123