Constrain getindex arg type in @selectors macro#41
Merged
Conversation
…iguities (#40) The @selectors macro generated `getindex(x::T, arg)` with unconstrained `arg`, causing method ambiguities in packages that define getindex on AbstractArray with specific index types (e.g. Reactant.jl). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks! Can we also get a new release which includes this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getindexmethod causes ambiguity downstream #40@selectorsmacro generatedBase.getindex(x::$T, arg)with completely unconstrainedarg, causing method ambiguities in downstream packages that definegetindexonAbstractArraywith specific index types (e.g. Reactant.jl#2398)SelectorIndextype alias (Union{KeyInd, Integer, Colon, Inds}) covering exactly the types that_getindexaccepts, and constrained the macro-generated method to use itTest plan
Pkg.test()— 251 tests)TracedRNumber{Int64}(not subtypes ofInteger) no longer match the constrained method, eliminating the reported ambiguity🤖 Generated with Claude Code