Remove ErrorResult, adopt exception-based error model#1246
Closed
Remove ErrorResult, adopt exception-based error model#1246
Conversation
Add HTTPVersion and header helper APIs. Implement request options: copyheaders, basicauth, canonicalize_headers, detect_content_type, proxy/pool, logerrors/logtag. Fix request/body handling, stream error propagation, websocket control frames, and header duplication. Add tests for headers, httpversion, client options, and websocket ping/pong.
Implement HTTP.open with streaming IO for requests/responses. - Add stream IO methods, lifecycle control, and GC rooting - Prepare HTTP/1 chunked requests before stream creation - Add client streaming tests for GET and POST
Add listen/listen! wrappers and blocking serve. - Enable stream handlers with request-body streaming and chunked responses - Add server stream helpers (setstatus/setheader) and tests
- track control frames and fragmented messages - add close handling with error propagation - cover fragmentation/close in tests
- gate retries by idempotency and body retryability - honor retry_delays and retry_check overrides - track retry counts in response metrics - add retry behavior tests
Adapt to Reseau's new exception-based error model: - Replace AwsIO module references with Reseau.Sockets - Fix channel_slot_send_message result check (now returns nothing) - Change WsChannelHandler vtable methods from ::Int to ::Nothing - Fix unsafe_string call on Reseau.error_str (returns String, not Ptr) - Update tests for new error patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AwsIOmodule references withReseau.Socketschannel_slot_send_messageresult check instream.jl(now returnsnothing, throws on error)WsChannelHandlervtable methods from::Intto::Nothingunsafe_stringcall onReseau.error_str(returnsString, notPtr)Note: This branch is based on
jq-http2which has in-progress HTTP/2 work. Some server/client integration test failures are pre-existing from that branch, not caused by ErrorResult removal.Test plan
🤖 Generated with Claude Code