DKMS changes

[anandhk-juniper]

Create one new package 'contrail-vrouter-src-dkms' that will have the 'vrouter' kernel module sources and the required sandesh files to compile the module in any system.

[ndramesh]

Instead of individually selecting each of the files, can't we tar the entire directory and put the tarball?

This way whenever we add or delete files in the source, we don't have to modify the spec/rules file.

[anandhk-juniper]

Hello ND,

There are a couple of problems in tar-ing (though, none are signifcant). Firstly,

it is possible that there could be binary files in the same directory. Secondly, not

all the files inside the vrouter directory is copied. Thirdly, all the sources don't

actually come from the same directory. However, I agree to the point that people

can forget adding files into the spec file. I do not have a good solution for this.

Let me know.

Thanks,

Anand

---

From: ndramesh notifications@github.com
Sent: Saturday, April 5, 2014 6:44 AM
To: Juniper/contrail-packaging
Cc: Anand H Krishnan
Subject: Re: [contrail-packaging] DKMS changes (#200)

In common/debian/contrail-vrouter-src-dkms/debian/rules:

• install -d -m 755 $(_packagedir)/sandesh
  

• install -d -m 755 $(_packagedir)/sandesh/gen-c/
  

• install -d -m 755 $(_packagedir)/sandesh/library/c
  

• install -d -m 755 $(_packagedir)/sandesh/library/c/protocol
  

• install -d -m 755 $(_packagedir)/sandesh/library/c/transport
  

• echo "MAKE[0]=\"'make' -C . KERNELDIR=/lib/modules/\$${kernelver}/build\"" >> $(_packagedir)/dkms.conf
  

• echo "CLEAN[0]=\"'make' -C . KERNELDIR=/lib/modules/\$${kernelver}/build\"" >> $(_packagedir)/dkms.conf
  

• echo "DEST_MODULE_LOCATION[0]=\"/kernel/extra/net/vrouter\"" >> $(_packagedir)/dkms.conf
  

• echo "BUILT_MODULE_NAME[0]=\"vrouter\"" >> $(_packagedir)/dkms.conf
  

• echo "PACKAGE_NAME=vrouter" >> $(_packagedir)/dkms.conf
  

• echo "PACKAGE_VERSION=$(BUILDTAG)" >> $(_packagedir)/dkms.conf
  

• echo "AUTOINSTALL=\"yes\"" >> $(_packagedir)/dkms.conf
  

• install -p -m 755 $(_srcdir)/dp-core/SConscript $(_packagedir)/dp-core/SConscript
  

Instead of individually selecting each of the files, can't we tar the entire directory and put the tarball?

This way whenever we add or delete files in the source, we don't have to modify the spec/rules file.

Reply to this email directly or view it on GitHubhttps://github.com//pull/200/files#r11319153.