Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
jsoref
left a comment
There was a problem hiding this comment.
Corrections were generally suggested by Google Sheets. But every choice is my fault.
Of the last couple of PRs I've made around GitHub this has by far the most things proportionally that I suspect will be rejected by a project.
If certain files/paths should be excluded, it's fairly trivial for me to drop items, just let me know.
Similarly, if a specific correction family is incorrect, I can trivially drop the commit, just let me know.
(I might be slow to respond until January, this was queued a while ago but I only got around to processing it tonight.)
| - name: creating firewall policy with draft mode state property defined should fail | ||
| request: | ||
| path: /firewall-policys | ||
| path: /firewall-policies |
There was a problem hiding this comment.
I don't understand this, so I expect this isn't a correct change
| - name: create forwarding class | ||
| request: | ||
| path: /forwarding-classs | ||
| path: /forwarding-class |
| - name: create network policy with security group entries | ||
| request: | ||
| path: /network-policys | ||
| path: /network-policies |
| admin_project_with_network_policy1: &admin_project_with_network_policy1 | ||
| <<: *admin_project | ||
| network_policys: | ||
| network_policies: |
| request: | ||
| # TODO: parent_id is temporary fix as tests in gen_db_test.go are not cleaning database. | ||
| path: /network-policys?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80 | ||
| path: /network-policies?parent_id=47dd9220-9bf1-11e9-b422-538349e2da80 |
| defaultTimeout = 30 * time.Second | ||
| ) | ||
|
|
||
| // Config represents parameters of Сollector in the config file |
| }{ | ||
| { | ||
| name: "Get multiple metadatas using UUID and FQName", | ||
| name: "Get multiple metadata using UUID and FQName", |
There was a problem hiding this comment.
data is plural, although this sounds wrong both ways.
| obj := struct { | ||
| *alias | ||
| Policys interface{} `json:"policys"` | ||
| Policies interface{} `json:"policies"` |
There was a problem hiding this comment.
It's possible that a thing like this is an api break and thus unacceptable.
| } | ||
|
|
||
| func (r *NetworkResponse) setPolicys(vn *models.VirtualNetwork) { | ||
| func (r *NetworkResponse) setPolicies(vn *models.VirtualNetwork) { |
There was a problem hiding this comment.
It's possible that this is a public api and thus unacceptable
| // Here nil is returned - same as original config node | ||
| // However this silently discards mac address update request if not allowed | ||
| func (port *Port) getAsssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string { | ||
| func (port *Port) getAssociatedVirtualMachineID(vmi *models.VirtualMachineInterface) string { |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@8e98257#commitcomment-60980950
The action reports that the changes in this PR would make it happy: jsoref@89d24b1
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.