Sprint 10. Controllers films users #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 13, 2024 20:02
Checkstyle
Checkstyle
Checkstyle
irek-valiev
reviewed
Dec 13, 2024
| private void validateReleaseDate(Film film) { | ||
| log.debug("validateReleaseDate start for {}", film); | ||
| LocalDate birthdayFilm = LocalDate.of(1895, 12, 28); | ||
| if (film.getReleaseDate() != null) { |
There was a problem hiding this comment.
у фильма может не быть описания (это ведь кто-то должен его написать), но вот отсутствие даты выпуска уже повод бросить исключение. Можно это реализовать здесь или в классе Film через аннотацию @NotNull
| } | ||
| } | ||
|
|
||
| private void validateCloneName(Film film) { |
There was a problem hiding this comment.
спорная проверка, в Задании нет требований, чтобы наименование фильма было уникальным, да и в жизни не мало фильмов с одинаковым названием
| log.debug("POST, create user {}", user); | ||
| cloneSearchEmail(user); | ||
| user.setId(getNextId()); | ||
| if (user.getName() == null) { |
There was a problem hiding this comment.
эта логика нужна и в методе update(), поэтому лучше вынести в отдельный внутренний метод и переиспользовать
| private String description; | ||
| private LocalDate releaseDate; | ||
| @Positive | ||
| private Integer duration; |
There was a problem hiding this comment.
для этого поля еще нужна аннотация @NotNull с комментарием
| private String login; | ||
| private String name; | ||
| @Past | ||
| private LocalDate birthday; |
irek-valiev
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.